Repository navigation
Conversation
The read-only role now covers the api.kagent.dev resources served by kagent's latest API (v1alpha3): agents, agenttemplates, egresspolicies, harnesses, modelconfigs, modelproviderconfigs, remotemcpservers and sandboxtemplates. Full-access mode already covers them. Signed-off-by: Dmytro Rashko <dimetron@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With
rbac.readOnly: true, the chart's read-only role had no access to kagent's own CRDs, so tools likek8s_get_resourcescould not read Agents, ModelConfigs, and other kagent resources.This change adds
get/list/watchon theapi.kagent.devresources in kagent's latest API (v1alpha3). The list matches the kagent chart's reconciliation role:Full-access mode (
rbac.readOnly: false) already covers these resources, so it is unchanged. The new rule also applies to namespaced Roles (rbac.namespaces).Testing
helm unittestcase.make helm-testpasses (24/24).helm template --set rbac.readOnly=truerenders the new rule.